<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/22383">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_pcu: Use libosmocore osmo_cgi_ps_cmp API<br><br>it was noticed that gprs_pcu_get_bts_by_cgi_ps() sometimes failed to<br>return the BTS even if the CGI-PS fields matched, probably due to memcmp<br>checking too padding bytes which may not be zero-initialized in one of<br>the two memory regions being checked. Let's be on the safe side and use<br>libosmocore APIs to check them.<br><br>Depends: libosmocore.git Change-Id I00e329bc5be8674b30267dec238e7656ddfc21db<br>Change-Id: I7c8ee2c447634e45b367bb8f84adf0140ae48591<br>---<br>M src/gprs_pcu.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_pcu.c b/src/gprs_pcu.c</span><br><span>index 32259b8..2f18dfd 100644</span><br><span>--- a/src/gprs_pcu.c</span><br><span>+++ b/src/gprs_pcu.c</span><br><span>@@ -120,7 +120,7 @@</span><br><span> {</span><br><span>   struct gprs_rlcmac_bts *pos;</span><br><span>         llist_for_each_entry(pos, &pcu->bts_list, list) {</span><br><span style="color: hsl(0, 100%, 40%);">-                if (memcmp(&pos->cgi_ps, cgi_ps, sizeof(*cgi_ps)) == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                if (osmo_cgi_ps_cmp(&pos->cgi_ps, cgi_ps) == 0)</span><br><span>                       return pos;</span><br><span>  }</span><br><span>    return NULL;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/22383">change 22383</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/22383"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7c8ee2c447634e45b367bb8f84adf0140ae48591 </div>
<div style="display:none"> Gerrit-Change-Number: 22383 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>