Change in libosmocore[master]: Revert "gprs_ns2_vc_fsm: check NSEI match the NSE"

[laforge]

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/22358 )


Change subject: Revert "gprs_ns2_vc_fsm: check NSEI match the NSE"
......................................................................

Revert "gprs_ns2_vc_fsm: check NSEI match the NSE"

This reverts commit 842599ca6252b9d65504fbe55148c6aad86f7025.
Closes: OS#4965

Change-Id: I96882961e179bb63e3f4095571135244148dde20
---
M src/gb/gprs_ns2_vc_fsm.c
1 file changed, 0 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/58/22358/1

diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c
index 3ec6909..fc2a86a 100644
--- a/src/gb/gprs_ns2_vc_fsm.c
+++ b/src/gb/gprs_ns2_vc_fsm.c
@@ -750,7 +750,6 @@
 	struct osmo_fsm_inst *fi = nsvc->fi;
 	int rc = 0;
 	uint8_t cause;
-	uint16_t nsei;
 
 	/* TODO: 7.2: on UNBLOCK/BLOCK: check if NS-VCI is correct,
 	 *  if not answer STATUS with "NS-VC unknown" */
@@ -764,19 +763,6 @@
 		}
 	}
 
-	if (TLVP_PRESENT(tp, NS_IE_NSEI)) {
-		nsei = tlvp_val16be(tp, NS_IE_NSEI);
-		if (nsei != nsvc->nse->nsei) {
-			/* 48.016 § 7.3.1 send, RESET_ACK to wrong NSVCI + ignore */
-			if (nsh->pdu_type == NS_PDUT_RESET)
-				ns2_tx_reset_ack(nsvc);
-
-			LOGNSVC(nsvc, LOGL_ERROR, "Rx %s with wrong NSEI=%05u. Ignoring PDU.\n",
-				get_value_string(gprs_ns_pdu_strings, nsh->pdu_type), nsei);
-			goto out;
-		}
-	}
-
 	switch (nsh->pdu_type) {
 	case NS_PDUT_RESET:
 		osmo_fsm_inst_dispatch(fi, GPRS_NS2_EV_RX_RESET, tp);

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22358
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I96882961e179bb63e3f4095571135244148dde20
Gerrit-Change-Number: 22358
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210121/80550a9e/attachment.htm>