<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22358">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "gprs_ns2_vc_fsm: check NSEI match the NSE"<br><br>This reverts commit 842599ca6252b9d65504fbe55148c6aad86f7025.<br>Closes: OS#4965<br><br>Change-Id: I96882961e179bb63e3f4095571135244148dde20<br>---<br>M src/gb/gprs_ns2_vc_fsm.c<br>1 file changed, 0 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/58/22358/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c</span><br><span>index 3ec6909..fc2a86a 100644</span><br><span>--- a/src/gb/gprs_ns2_vc_fsm.c</span><br><span>+++ b/src/gb/gprs_ns2_vc_fsm.c</span><br><span>@@ -750,7 +750,6 @@</span><br><span>        struct osmo_fsm_inst *fi = nsvc->fi;</span><br><span>      int rc = 0;</span><br><span>  uint8_t cause;</span><br><span style="color: hsl(0, 100%, 40%);">-  uint16_t nsei;</span><br><span> </span><br><span>   /* TODO: 7.2: on UNBLOCK/BLOCK: check if NS-VCI is correct,</span><br><span>   *  if not answer STATUS with "NS-VC unknown" */</span><br><span>@@ -764,19 +763,6 @@</span><br><span>            }</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (TLVP_PRESENT(tp, NS_IE_NSEI)) {</span><br><span style="color: hsl(0, 100%, 40%);">-             nsei = tlvp_val16be(tp, NS_IE_NSEI);</span><br><span style="color: hsl(0, 100%, 40%);">-            if (nsei != nsvc->nse->nsei) {</span><br><span style="color: hsl(0, 100%, 40%);">-                    /* 48.016 § 7.3.1 send, RESET_ACK to wrong NSVCI + ignore */</span><br><span style="color: hsl(0, 100%, 40%);">-                   if (nsh->pdu_type == NS_PDUT_RESET)</span><br><span style="color: hsl(0, 100%, 40%);">-                          ns2_tx_reset_ack(nsvc);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-                 LOGNSVC(nsvc, LOGL_ERROR, "Rx %s with wrong NSEI=%05u. Ignoring PDU.\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                              get_value_string(gprs_ns_pdu_strings, nsh->pdu_type), nsei);</span><br><span style="color: hsl(0, 100%, 40%);">-                 goto out;</span><br><span style="color: hsl(0, 100%, 40%);">-               }</span><br><span style="color: hsl(0, 100%, 40%);">-       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    switch (nsh->pdu_type) {</span><br><span>  case NS_PDUT_RESET:</span><br><span>          osmo_fsm_inst_dispatch(fi, GPRS_NS2_EV_RX_RESET, tp);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22358">change 22358</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22358"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I96882961e179bb63e3f4095571135244148dde20 </div>
<div style="display:none"> Gerrit-Change-Number: 22358 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>