Change in osmo-sgsn[master]: gb_proxy: Don't use orphan log subsystem DPCU

[laforge]

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22279 )


Change subject: gb_proxy: Don't use orphan log subsystem DPCU
......................................................................

gb_proxy: Don't use orphan log subsystem DPCU

DPCU is defined in debug.h, but never registered as log subsystem,
so we shall not use it.  Also remove other similar "orphan" log
subsystems from debug.h

Change-Id: I8be54ee49e10d4004128352613923c4700063aa3
---
M include/osmocom/sgsn/debug.h
M src/gbproxy/gb_proxy.c
2 files changed, 5 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/79/22279/1

diff --git a/include/osmocom/sgsn/debug.h b/include/osmocom/sgsn/debug.h
index da819d5..9a686cb 100644
--- a/include/osmocom/sgsn/debug.h
+++ b/include/osmocom/sgsn/debug.h
@@ -8,34 +8,21 @@
 
 /* Debug Areas of the code */
 enum {
-	DRLL,
-	DCC,
 	DMM,
-	DRR,
-	DRSL,
-	DNM,
-	DMNCC,
 	DPAG,
 	DMEAS,
-	DSCCP,
-	DMSC,
-	DHO,
-	DDB,
 	DREF,
 	DGPRS,
 	DNS,
 	DLLC,
 	DSNDCP,
 	DSLHC,
-	DNAT,
 	DCTRL,
 	DFILTER,
 	DGTPHUB,
 	DRANAP,
 	DSUA,
 	DV42BIS,
-	DPCU,
-	DVLR,
 	DIUCS,
 	DSIGTRAN,
 	DGTP,
diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index 7f8260c..89520c2 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -1287,7 +1287,7 @@
 		break;
 
 	case NS_AFF_CAUSE_RECOVERY:
-		LOGP(DPCU, LOGL_NOTICE, "NS-NSE %d became available\n", nsp->nsei);
+		LOGP(DGPRS, LOGL_NOTICE, "NS-NSE %d became available\n", nsp->nsei);
 		sgsn_nse = gbproxy_nse_by_nsei(cfg, nsp->nsei, NSE_F_SGSN);
 		if (sgsn_nse) {
 			uint8_t cause = BSSGP_CAUSE_OML_INTERV;
@@ -1321,10 +1321,10 @@
 			}
 		}
 #endif
-		LOGP(DPCU, LOGL_NOTICE, "NS-NSE %d became unavailable\n", nsp->nsei);
+		LOGP(DGPRS, LOGL_NOTICE, "NS-NSE %d became unavailable\n", nsp->nsei);
 		break;
 	default:
-		LOGP(DPCU, LOGL_NOTICE, "NS: Unknown NS-STATUS.ind cause=%s from NS\n",
+		LOGP(DGPRS, LOGL_NOTICE, "NS: Unknown NS-STATUS.ind cause=%s from NS\n",
 		     gprs_ns2_aff_cause_prim_str(nsp->u.status.cause));
 		break;
 	}
@@ -1344,7 +1344,7 @@
 	nsp = container_of(oph, struct osmo_gprs_ns2_prim, oph);
 
 	if (oph->operation != PRIM_OP_INDICATION) {
-		LOGP(DPCU, LOGL_NOTICE, "NS: Unexpected primitive operation %s from NS\n",
+		LOGP(DGPRS, LOGL_NOTICE, "NS: Unexpected primitive operation %s from NS\n",
 		     get_value_string(osmo_prim_op_names, oph->operation));
 		return 0;
 	}
@@ -1366,7 +1366,7 @@
 		gprs_ns_prim_status_cb(cfg, nsp);
 		break;
 	default:
-		LOGP(DPCU, LOGL_NOTICE, "NS: Unknown prim %s %s from NS\n",
+		LOGP(DGPRS, LOGL_NOTICE, "NS: Unknown prim %s %s from NS\n",
 		     gprs_ns2_prim_str(oph->primitive),
 		     get_value_string(osmo_prim_op_names, oph->operation));
 		break;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/22279
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I8be54ee49e10d4004128352613923c4700063aa3
Gerrit-Change-Number: 22279
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210118/1afa73c6/attachment.htm>