<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/22279">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gb_proxy: Don't use orphan log subsystem DPCU<br><br>DPCU is defined in debug.h, but never registered as log subsystem,<br>so we shall not use it. Also remove other similar "orphan" log<br>subsystems from debug.h<br><br>Change-Id: I8be54ee49e10d4004128352613923c4700063aa3<br>---<br>M include/osmocom/sgsn/debug.h<br>M src/gbproxy/gb_proxy.c<br>2 files changed, 5 insertions(+), 18 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/79/22279/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/sgsn/debug.h b/include/osmocom/sgsn/debug.h</span><br><span>index da819d5..9a686cb 100644</span><br><span>--- a/include/osmocom/sgsn/debug.h</span><br><span>+++ b/include/osmocom/sgsn/debug.h</span><br><span>@@ -8,34 +8,21 @@</span><br><span> </span><br><span> /* Debug Areas of the code */</span><br><span> enum {</span><br><span style="color: hsl(0, 100%, 40%);">- DRLL,</span><br><span style="color: hsl(0, 100%, 40%);">- DCC,</span><br><span> DMM,</span><br><span style="color: hsl(0, 100%, 40%);">- DRR,</span><br><span style="color: hsl(0, 100%, 40%);">- DRSL,</span><br><span style="color: hsl(0, 100%, 40%);">- DNM,</span><br><span style="color: hsl(0, 100%, 40%);">- DMNCC,</span><br><span> DPAG,</span><br><span> DMEAS,</span><br><span style="color: hsl(0, 100%, 40%);">- DSCCP,</span><br><span style="color: hsl(0, 100%, 40%);">- DMSC,</span><br><span style="color: hsl(0, 100%, 40%);">- DHO,</span><br><span style="color: hsl(0, 100%, 40%);">- DDB,</span><br><span> DREF,</span><br><span> DGPRS,</span><br><span> DNS,</span><br><span> DLLC,</span><br><span> DSNDCP,</span><br><span> DSLHC,</span><br><span style="color: hsl(0, 100%, 40%);">- DNAT,</span><br><span> DCTRL,</span><br><span> DFILTER,</span><br><span> DGTPHUB,</span><br><span> DRANAP,</span><br><span> DSUA,</span><br><span> DV42BIS,</span><br><span style="color: hsl(0, 100%, 40%);">- DPCU,</span><br><span style="color: hsl(0, 100%, 40%);">- DVLR,</span><br><span> DIUCS,</span><br><span> DSIGTRAN,</span><br><span> DGTP,</span><br><span>diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c</span><br><span>index 7f8260c..89520c2 100644</span><br><span>--- a/src/gbproxy/gb_proxy.c</span><br><span>+++ b/src/gbproxy/gb_proxy.c</span><br><span>@@ -1287,7 +1287,7 @@</span><br><span> break;</span><br><span> </span><br><span> case NS_AFF_CAUSE_RECOVERY:</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DPCU, LOGL_NOTICE, "NS-NSE %d became available\n", nsp->nsei);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DGPRS, LOGL_NOTICE, "NS-NSE %d became available\n", nsp->nsei);</span><br><span> sgsn_nse = gbproxy_nse_by_nsei(cfg, nsp->nsei, NSE_F_SGSN);</span><br><span> if (sgsn_nse) {</span><br><span> uint8_t cause = BSSGP_CAUSE_OML_INTERV;</span><br><span>@@ -1321,10 +1321,10 @@</span><br><span> }</span><br><span> }</span><br><span> #endif</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DPCU, LOGL_NOTICE, "NS-NSE %d became unavailable\n", nsp->nsei);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DGPRS, LOGL_NOTICE, "NS-NSE %d became unavailable\n", nsp->nsei);</span><br><span> break;</span><br><span> default:</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DPCU, LOGL_NOTICE, "NS: Unknown NS-STATUS.ind cause=%s from NS\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DGPRS, LOGL_NOTICE, "NS: Unknown NS-STATUS.ind cause=%s from NS\n",</span><br><span> gprs_ns2_aff_cause_prim_str(nsp->u.status.cause));</span><br><span> break;</span><br><span> }</span><br><span>@@ -1344,7 +1344,7 @@</span><br><span> nsp = container_of(oph, struct osmo_gprs_ns2_prim, oph);</span><br><span> </span><br><span> if (oph->operation != PRIM_OP_INDICATION) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DPCU, LOGL_NOTICE, "NS: Unexpected primitive operation %s from NS\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DGPRS, LOGL_NOTICE, "NS: Unexpected primitive operation %s from NS\n",</span><br><span> get_value_string(osmo_prim_op_names, oph->operation));</span><br><span> return 0;</span><br><span> }</span><br><span>@@ -1366,7 +1366,7 @@</span><br><span> gprs_ns_prim_status_cb(cfg, nsp);</span><br><span> break;</span><br><span> default:</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DPCU, LOGL_NOTICE, "NS: Unknown prim %s %s from NS\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DGPRS, LOGL_NOTICE, "NS: Unknown prim %s %s from NS\n",</span><br><span> gprs_ns2_prim_str(oph->primitive),</span><br><span> get_value_string(osmo_prim_op_names, oph->operation));</span><br><span> break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/22279">change 22279</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/22279"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8be54ee49e10d4004128352613923c4700063aa3 </div>
<div style="display:none"> Gerrit-Change-Number: 22279 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>