This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22265 ) Change subject: hodec2: fix congestion resolution on dyn TS ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/22265/1/src/osmo-bsc/handover_decision_2.c File src/osmo-bsc/handover_decision_2.c: https://gerrit.osmocom.org/c/osmo-bsc/+/22265/1/src/osmo-bsc/handover_decision_2.c@644 PS1, Line 644: if (c->target.free_tchf - 1 >= c->target.min_free_tchf I'd probably add () around this comparisong and the operationbelow for clearness: (c->target.free_tchh - c->target.next_tchf_reduces_tchh) Not critical though. https://gerrit.osmocom.org/c/osmo-bsc/+/22265/1/src/osmo-bsc/handover_decision_2.c@923 PS1, Line 923: /* Would the next TCH/F lchan convert a dynamic timeslot that currently counts for free TCH/H timeslots? */ Convert into what? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1536b60f03cb0aeb6ba14a72b518aec82fa572fe Gerrit-Change-Number: 22265 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 18 Jan 2021 10:15:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210118/32d21b91/attachment.htm>