<p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22265">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22265/1/src/osmo-bsc/handover_decision_2.c">File src/osmo-bsc/handover_decision_2.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22265/1/src/osmo-bsc/handover_decision_2.c@644">Patch Set #1, Line 644:</a> <code style="font-family:monospace,monospace">             if (c->target.free_tchf - 1 >= c->target.min_free_tchf</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd probably add () around this comparisong and the operationbelow for clearness:<br>(c->target.free_tchh - c->target.next_tchf_reduces_tchh)</p><p style="white-space: pre-wrap; word-wrap: break-word;">Not critical though.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22265/1/src/osmo-bsc/handover_decision_2.c@923">Patch Set #1, Line 923:</a> <code style="font-family:monospace,monospace">    /* Would the next TCH/F lchan convert a dynamic timeslot that currently counts for free TCH/H timeslots? */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Convert into what?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22265">change 22265</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/22265"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1536b60f03cb0aeb6ba14a72b518aec82fa572fe </div>
<div style="display:none"> Gerrit-Change-Number: 22265 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 18 Jan 2021 10:15:37 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>