Change in osmo-bsc[master]: gsm_data: log the actual MS Power class changes, not x -> x

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jan 15 20:47:57 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22232 )

Change subject: gsm_data: log the actual MS Power class changes, not x -> x
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/22232/1/src/osmo-bsc/gsm_data.c 
File src/osmo-bsc/gsm_data.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/22232/1/src/osmo-bsc/gsm_data.c@845 
PS1, Line 845: 	if (conn->ms_power_class != power_class) {
A more radical approach would be to return early. Do we have to call lchan_update_ms_power_ctrl_level() even if conn->ms_power_class == power_class?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22232
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I519d2d1575cbb5352cc381a60513db8e0e2cb0a0
Gerrit-Change-Number: 22232
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 15 Jan 2021 20:47:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210115/c13ed7c9/attachment.htm>


More information about the gerrit-log mailing list