Change in osmo-bsc[master]: gsm_data: log the actual MS Power class changes, not x -> x

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22232 )


Change subject: gsm_data: log the actual MS Power class changes, not x -> x
......................................................................

gsm_data: log the actual MS Power class changes, not x -> x

The following message makes no sense:

  DRLL DEBUG gsm_data.c:844 MS Power class update: 4 -> 4

because nothing really changed, MS Power class remains 4.

Change-Id: I519d2d1575cbb5352cc381a60513db8e0e2cb0a0
---
M src/osmo-bsc/gsm_data.c
1 file changed, 5 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/32/22232/1

diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index 38392fc..e08e7da 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -841,10 +841,12 @@
 void conn_update_ms_power_class(struct gsm_subscriber_connection *conn, uint8_t power_class)
 {
 	struct gsm_bts *bts = conn_get_bts(conn);
-	LOGP(DRLL, LOGL_DEBUG, "MS Power class update: %" PRIu8 " -> %" PRIu8 "\n",
-	     conn->ms_power_class, power_class);
 
-	conn->ms_power_class = power_class;
+	if (conn->ms_power_class != power_class) {
+		LOGP(DRLL, LOGL_DEBUG, "MS Power class update: %" PRIu8 " -> %" PRIu8 "\n",
+		     conn->ms_power_class, power_class);
+		conn->ms_power_class = power_class;
+	}
 
 	/* If there's an associated lchan, attempt to update its max power to be
 	   on track with band maximum values */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22232
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I519d2d1575cbb5352cc381a60513db8e0e2cb0a0
Gerrit-Change-Number: 22232
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210115/74c49312/attachment.htm>