Change in libosmocore[master]: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22046 )

Change subject: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/22046/5/include/osmocom/gprs/gprs_bssgp.h 
File include/osmocom/gprs/gprs_bssgp.h:

https://gerrit.osmocom.org/c/libosmocore/+/22046/5/include/osmocom/gprs/gprs_bssgp.h@50 
PS5, Line 50: 	const uint8_t *rim_cont;
I still don't see why you don't want to use a struct holding a union of container types here, so the entire message can be encoded in one go. Is there some problem I'm not seeing?


https://gerrit.osmocom.org/c/libosmocore/+/22046/5/include/osmocom/gprs/gprs_bssgp_rim.h 
File include/osmocom/gprs/gprs_bssgp_rim.h:

https://gerrit.osmocom.org/c/libosmocore/+/22046/5/include/osmocom/gprs/gprs_bssgp_rim.h@121 
PS5, Line 121: struct bssgp_ran_inf_req_rim_cont {
Why isn't there a generic container struct containing in a union this struct here and other container types?
It can then be passed instead of already-encoded buffer to do encoding in one message.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22046
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I18134fd9938040d2facb6beee3732628b167ce8c
Gerrit-Change-Number: 22046
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Jan 2021 17:24:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210114/7e0c5bda/attachment.htm>