<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22046">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22046/5/include/osmocom/gprs/gprs_bssgp.h">File include/osmocom/gprs/gprs_bssgp.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22046/5/include/osmocom/gprs/gprs_bssgp.h@50">Patch Set #5, Line 50:</a> <code style="font-family:monospace,monospace"> const uint8_t *rim_cont;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I still don't see why you don't want to use a struct holding a union of container types here, so the entire message can be encoded in one go. Is there some problem I'm not seeing?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22046/5/include/osmocom/gprs/gprs_bssgp_rim.h">File include/osmocom/gprs/gprs_bssgp_rim.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22046/5/include/osmocom/gprs/gprs_bssgp_rim.h@121">Patch Set #5, Line 121:</a> <code style="font-family:monospace,monospace">struct bssgp_ran_inf_req_rim_cont {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why isn't there a generic container struct containing in a union this struct here and other container types?<br>It can then be passed instead of already-encoded buffer to do encoding in one message.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22046">change 22046</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22046"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I18134fd9938040d2facb6beee3732628b167ce8c </div>
<div style="display:none"> Gerrit-Change-Number: 22046 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 14 Jan 2021 17:24:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>