This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21949 ) Change subject: gprs_bssgp: abuse gsm48_encode_ra() to encode TAC ...................................................................... gprs_bssgp: abuse gsm48_encode_ra() to encode TAC Both LAC and TAC take 2 octets and follow MCC/MNC fields on the wire. We abuse gsm48_encode_ra() for encoding of MCC/MNC, but it can also be abused to encode TAC in bssgp_create_rim_ri(). There is no need to encode '0000'O and then override it with osmo_store16be(). Change-Id: I986552aa52cf38b1c5290d2e5cd3ff2d1c36a4e5 --- M src/gb/gprs_bssgp.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c index bf0e821..530c702 100644 --- a/src/gb/gprs_bssgp.c +++ b/src/gb/gprs_bssgp.c @@ -402,10 +402,11 @@ .mcc = ri->eutran.tai.mcc, .mnc = ri->eutran.tai.mnc, .mnc_3_digits = ri->eutran.tai.mnc_3_digits, + /* TAC is encoded in the same way as LAC */ + .lac = ri->eutran.tai.tac, }; gsm48_encode_ra((struct gsm48_ra_id *)buf, &raid_temp); - osmo_store16be(ri->eutran.tai.tac, buf + 3); OSMO_ASSERT(ri->eutran.global_enb_id_len <= sizeof(ri->eutran.global_enb_id)); memcpy(buf + 5, ri->eutran.global_enb_id, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I986552aa52cf38b1c5290d2e5cd3ff2d1c36a4e5 Gerrit-Change-Number: 21949 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210111/87d8e662/attachment.htm>