<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21949">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_bssgp: abuse gsm48_encode_ra() to encode TAC<br><br>Both LAC and TAC take 2 octets and follow MCC/MNC fields on the wire.<br>We abuse gsm48_encode_ra() for encoding of MCC/MNC, but it can also<br>be abused to encode TAC in bssgp_create_rim_ri().  There is no need<br>to encode '0000'O and then override it with osmo_store16be().<br><br>Change-Id: I986552aa52cf38b1c5290d2e5cd3ff2d1c36a4e5<br>---<br>M src/gb/gprs_bssgp.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c</span><br><span>index bf0e821..530c702 100644</span><br><span>--- a/src/gb/gprs_bssgp.c</span><br><span>+++ b/src/gb/gprs_bssgp.c</span><br><span>@@ -402,10 +402,11 @@</span><br><span>                    .mcc = ri->eutran.tai.mcc,</span><br><span>                        .mnc = ri->eutran.tai.mnc,</span><br><span>                        .mnc_3_digits = ri->eutran.tai.mnc_3_digits,</span><br><span style="color: hsl(120, 100%, 40%);">+                       /* TAC is encoded in the same way as LAC */</span><br><span style="color: hsl(120, 100%, 40%);">+                   .lac = ri->eutran.tai.tac,</span><br><span>                };</span><br><span> </span><br><span>               gsm48_encode_ra((struct gsm48_ra_id *)buf, &raid_temp);</span><br><span style="color: hsl(0, 100%, 40%);">-             osmo_store16be(ri->eutran.tai.tac, buf + 3);</span><br><span>              OSMO_ASSERT(ri->eutran.global_enb_id_len <=</span><br><span>                        sizeof(ri->eutran.global_enb_id));</span><br><span>            memcpy(buf + 5, ri->eutran.global_enb_id,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21949">change 21949</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21949"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I986552aa52cf38b1c5290d2e5cd3ff2d1c36a4e5 </div>
<div style="display:none"> Gerrit-Change-Number: 21949 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>