Change in osmo-hlr[master]: auc_test.c: Add some comments on what the test cases actually do

[laforge]

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/21933 )


Change subject: auc_test.c: Add some comments on what the test cases actually do
......................................................................

auc_test.c: Add some comments on what the test cases actually do

Change-Id: Id2b9cf12823e05aeadc6f15df396f8a46ae1639d
---
M tests/auc/auc_test.c
1 file changed, 11 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/33/21933/1

diff --git a/tests/auc/auc_test.c b/tests/auc/auc_test.c
index db7edcb..c0620db 100644
--- a/tests/auc/auc_test.c
+++ b/tests/auc/auc_test.c
@@ -113,6 +113,7 @@
 	return len;
 }
 
+/* Subscriber with 2G-only (COMP128v1) authentication data */
 static void test_gen_vectors_2g_only(void)
 {
 	struct osmo_sub_auth_data aud2g;
@@ -174,6 +175,8 @@
 	comment_end();
 }
 
+/* Subscriber with separate 2G (COMP128v1) and 3G (MILENAGE) authentication data,
+ * reflects the default configuration of sysmoUSIM-SJS1 */
 static void test_gen_vectors_2g_plus_3g(void)
 {
 	struct osmo_sub_auth_data aud2g;
@@ -284,6 +287,9 @@
 	      );
 }
 
+/* Subscriber with only 3G (MILENAGE) authentication data,
+ * reflects the default configuration of sysmoISIM-SJA2. Resulting
+ * tuples are suitable for both 2G and 3G authentication */
 static void test_gen_vectors_3g_only(void)
 {
 	struct osmo_sub_auth_data aud2g;
@@ -454,6 +460,10 @@
 	comment_end();
 }
 
+/* Subscriber with only 3G (XOR) authentication data,
+ * reflects the default configuration of sysmoTSIM-SJAx as well
+ * as many "Test USIM" cards. Resulting tuples are suitable for both
+ * 2G and 3G authentication */
 static void test_gen_vectors_3g_xor(void)
 {
 	struct osmo_sub_auth_data aud2g;
@@ -498,6 +508,7 @@
 	comment_end();
 }
 
+/* Test a variety of invalid authentication data combinations */
 void test_gen_vectors_bad_args()
 {
 	struct osmo_auth_vector vec;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/21933
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Id2b9cf12823e05aeadc6f15df396f8a46ae1639d
Gerrit-Change-Number: 21933
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210104/952b4da2/attachment.htm>