<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/21933">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">auc_test.c: Add some comments on what the test cases actually do<br><br>Change-Id: Id2b9cf12823e05aeadc6f15df396f8a46ae1639d<br>---<br>M tests/auc/auc_test.c<br>1 file changed, 11 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/33/21933/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/auc/auc_test.c b/tests/auc/auc_test.c</span><br><span>index db7edcb..c0620db 100644</span><br><span>--- a/tests/auc/auc_test.c</span><br><span>+++ b/tests/auc/auc_test.c</span><br><span>@@ -113,6 +113,7 @@</span><br><span>        return len;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Subscriber with 2G-only (COMP128v1) authentication data */</span><br><span> static void test_gen_vectors_2g_only(void)</span><br><span> {</span><br><span>       struct osmo_sub_auth_data aud2g;</span><br><span>@@ -174,6 +175,8 @@</span><br><span>       comment_end();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Subscriber with separate 2G (COMP128v1) and 3G (MILENAGE) authentication data,</span><br><span style="color: hsl(120, 100%, 40%);">+ * reflects the default configuration of sysmoUSIM-SJS1 */</span><br><span> static void test_gen_vectors_2g_plus_3g(void)</span><br><span> {</span><br><span>         struct osmo_sub_auth_data aud2g;</span><br><span>@@ -284,6 +287,9 @@</span><br><span>             );</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Subscriber with only 3G (MILENAGE) authentication data,</span><br><span style="color: hsl(120, 100%, 40%);">+ * reflects the default configuration of sysmoISIM-SJA2. Resulting</span><br><span style="color: hsl(120, 100%, 40%);">+ * tuples are suitable for both 2G and 3G authentication */</span><br><span> static void test_gen_vectors_3g_only(void)</span><br><span> {</span><br><span>    struct osmo_sub_auth_data aud2g;</span><br><span>@@ -454,6 +460,10 @@</span><br><span>      comment_end();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Subscriber with only 3G (XOR) authentication data,</span><br><span style="color: hsl(120, 100%, 40%);">+ * reflects the default configuration of sysmoTSIM-SJAx as well</span><br><span style="color: hsl(120, 100%, 40%);">+ * as many "Test USIM" cards. Resulting tuples are suitable for both</span><br><span style="color: hsl(120, 100%, 40%);">+ * 2G and 3G authentication */</span><br><span> static void test_gen_vectors_3g_xor(void)</span><br><span> {</span><br><span>    struct osmo_sub_auth_data aud2g;</span><br><span>@@ -498,6 +508,7 @@</span><br><span>       comment_end();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Test a variety of invalid authentication data combinations */</span><br><span> void test_gen_vectors_bad_args()</span><br><span> {</span><br><span>   struct osmo_auth_vector vec;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/21933">change 21933</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/21933"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id2b9cf12823e05aeadc6f15df396f8a46ae1639d </div>
<div style="display:none"> Gerrit-Change-Number: 21933 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>