Change in osmo-bts[master]: fix-up missed review comment in CBCH SI4 patching fix

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Jan 3 09:43:02 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21923 )

Change subject: fix-up missed review comment in CBCH SI4 patching fix
......................................................................

fix-up missed review comment in CBCH SI4 patching fix

This is a follow-up fix for I0ee0cf736e2fb74a6759a68101f699b4ec2ef54e

get_si4_ro_offset() itself already checks if it's less than GSM_MACBLOCK_LEN,
so we must check if it's not negative.

Change-Id: Iba99e5de625af6bed6720a38fec26c2acc6251c0
---
M src/common/rsl.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/common/rsl.c b/src/common/rsl.c
index 8e27e77..29b64b4 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -382,7 +382,7 @@
 			/* decode original SI4 Rest Octets as sent by BSC */
 			const uint8_t *si4 = (uint8_t *) GSM_BTS_SI(bts, osmo_si);
 			int si4_ro_offset = get_si4_ro_offset(si4);
-			if (si4_ro_offset < GSM_MACBLOCK_LEN) {
+			if (si4_ro_offset > 0) {
 				osmo_gsm48_rest_octets_si4_decode(&bts->si4_ro_decoded,
 								  si4 + si4_ro_offset,
 								  GSM_MACBLOCK_LEN - si4_ro_offset);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21923
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iba99e5de625af6bed6720a38fec26c2acc6251c0
Gerrit-Change-Number: 21923
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210103/dd1ab89a/attachment.htm>


More information about the gerrit-log mailing list