<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21923">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix-up missed review comment in CBCH SI4 patching fix<br><br>This is a follow-up fix for I0ee0cf736e2fb74a6759a68101f699b4ec2ef54e<br><br>get_si4_ro_offset() itself already checks if it's less than GSM_MACBLOCK_LEN,<br>so we must check if it's not negative.<br><br>Change-Id: Iba99e5de625af6bed6720a38fec26c2acc6251c0<br>---<br>M src/common/rsl.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index 8e27e77..29b64b4 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -382,7 +382,7 @@</span><br><span>                  /* decode original SI4 Rest Octets as sent by BSC */</span><br><span>                         const uint8_t *si4 = (uint8_t *) GSM_BTS_SI(bts, osmo_si);</span><br><span>                   int si4_ro_offset = get_si4_ro_offset(si4);</span><br><span style="color: hsl(0, 100%, 40%);">-                     if (si4_ro_offset < GSM_MACBLOCK_LEN) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    if (si4_ro_offset > 0) {</span><br><span>                          osmo_gsm48_rest_octets_si4_decode(&bts->si4_ro_decoded,</span><br><span>                                                                 si4 + si4_ro_offset,</span><br><span>                                                                 GSM_MACBLOCK_LEN - si4_ro_offset);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/21923">change 21923</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/21923"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iba99e5de625af6bed6720a38fec26c2acc6251c0 </div>
<div style="display:none"> Gerrit-Change-Number: 21923 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>