Change in osmo-bsc[master]: vty: join UL/DL SACCH repetition commands together

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Jan 2 22:46:27 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21911 )

Change subject: vty: join UL/DL SACCH repetition commands together
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/21911/2/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21911/2/src/osmo-bsc/bsc_vty.c@2820 
PS2, Line 2820: argv[0][0] == 'u')
> Done. Still not getting why people find strcmp() more readable...
because that is the condition.  The condition is not "is the first character u" but "is the entire parameter "ul-sacch". What if the code is later extended?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21911
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibe98718d8f4933926eed0e622109c9c82537f526
Gerrit-Change-Number: 21911
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 02 Jan 2021 22:46:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210102/e9884675/attachment.htm>


More information about the gerrit-log mailing list