Change in osmo-bsc[master]: vty: join UL/DL SACCH repetition commands together

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jan 1 15:55:59 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21911 )

Change subject: vty: join UL/DL SACCH repetition commands together
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/21911/2/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21911/2/src/osmo-bsc/bsc_vty.c@2820 
PS2, Line 2820: argv[0][0] == 'u')
> can we please do a proper !strcmp() to the string used in the command?
Done. Still not getting why people find strcmp() more readable...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21911
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibe98718d8f4933926eed0e622109c9c82537f526
Gerrit-Change-Number: 21911
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 01 Jan 2021 15:55:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210101/5b866151/attachment.htm>


More information about the gerrit-log mailing list