This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23123 ) Change subject: kernel-test: add KERNEL_TEST_KVM env var ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/docker-playground/+/23123/1/jenkins-common.sh File jenkins-common.sh: https://gerrit.osmocom.org/c/docker-playground/+/23123/1/jenkins-common.sh@198 PS1, Line 198: if [ "$KERNEL_TEST_KVM" != 0 ]; then iiuc you are doing string comparisong here, so better use "0"? or "z$KERNEL_TEST_KVM" != "z0" or whatever https://gerrit.osmocom.org/c/docker-playground/+/23123/1/jenkins-common.sh@221 PS1, Line 221: if [ "$KERNEL_TEST_KVM" != 0 ] && ! [ -e /dev/kvm ]; then Why not simply mounting /dev/kvm automatically if it exists? let's not add more flags which are not really needed? https://gerrit.osmocom.org/c/docker-playground/+/23123/1/ttcn3-ggsn-test/jenkins.sh File ttcn3-ggsn-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/23123/1/ttcn3-ggsn-test/jenkins.sh@68 PS1, Line 68: sleep 5 so it seems we finally need some sort of synchronization point? ;) Please add a comment explaining why is this needed. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/23123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1f337af1e2de6db05b22636bc31a535404235559 Gerrit-Change-Number: 23123 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 26 Feb 2021 12:49:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210226/84d309c2/attachment.htm>