<p><a href="https://gerrit.osmocom.org/c/docker-playground/+/23123">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/23123/1/jenkins-common.sh">File jenkins-common.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/23123/1/jenkins-common.sh@198">Patch Set #1, Line 198:</a> <code style="font-family:monospace,monospace">     if [ "$KERNEL_TEST_KVM" != 0 ]; then</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">iiuc you are doing string comparisong here, so better use "0"? or "z$KERNEL_TEST_KVM" !=  "z0" or whatever</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/23123/1/jenkins-common.sh@221">Patch Set #1, Line 221:</a> <code style="font-family:monospace,monospace"> if [ "$KERNEL_TEST_KVM" != 0 ] && ! [ -e /dev/kvm ]; then</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why not simply mounting /dev/kvm automatically if it exists? let's not add more flags which are not really needed?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/23123/1/ttcn3-ggsn-test/jenkins.sh">File ttcn3-ggsn-test/jenkins.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/23123/1/ttcn3-ggsn-test/jenkins.sh@68">Patch Set #1, Line 68:</a> <code style="font-family:monospace,monospace"> sleep 5</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">so it seems we finally need some sort of synchronization point? ;)<br>Please add a comment explaining why is this needed.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/docker-playground/+/23123">change 23123</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/docker-playground/+/23123"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1f337af1e2de6db05b22636bc31a535404235559 </div>
<div style="display:none"> Gerrit-Change-Number: 23123 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 26 Feb 2021 12:49:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>