This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23117 ) Change subject: RSL_Emulation: Get rid of module param mp_rslem_patch_ipa_cid ...................................................................... RSL_Emulation: Get rid of module param mp_rslem_patch_ipa_cid This param is not needed anymore since new releases used in -latest don't need to disable it. Change-Id: I39e9c1986ea682d54dcb22b31798ca91f1677949 Related: OS#5042 --- M library/RSL_Emulation.ttcn 1 file changed, 0 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/23117/1 diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn index 0a20459..f436c66 100644 --- a/library/RSL_Emulation.ttcn +++ b/library/RSL_Emulation.ttcn @@ -36,9 +36,6 @@ modulepar { - /* Work around switch for ttcn3-bts-test-latest, enables patching of IPA - * stream ID in the "BSC" mode. See I5927f59a49724170a63e87be604973f7c9d5d8be. */ - boolean mp_rslem_patch_ipa_cid := false; }; /* General "base class" component definition, of which specific implementations @@ -419,19 +416,6 @@ return TrxConnMap[trx_nr]; } -/* Work around for a bug in osmo-bts when all transceivers use IPAC_PROTO_RSL_TRX0 */ -private function f_trx_conn_map_patch_ud(inout ASP_RSL_Unitdata ud) -runs on RSL_Emulation_CT { - for (var integer i := 0; i < sizeof(TrxConnMap); i := i + 1) { - if (ud.conn_id == TrxConnMap[i]) { - ud.streamId := f_streamId_by_trx(i); - return; /* We're done */ - } - } - - testcase.stop("Failed to patch IPA stream ID in ASP RSL UD: ", ud); -} - private type record of ASP_RSL_Unitdata ASP_RSL_UDList; type component RSL_Emulation_CT { @@ -587,17 +571,11 @@ /* Forward common channel management to the special port for it */ [] IPA_PT.receive(tr_ASP_RSL_UD(tr_RSL_MsgTypeT(?), sid := ?)) -> value rx_rsl { - if (not bts_role and mp_rslem_patch_ipa_cid) { - f_trx_conn_map_patch_ud(rx_rsl); - } CCHAN_PT.send(rx_rsl); } /* Forward common channel management to the special port for it */ [] IPA_PT.receive(tr_ASP_RSL_UD(tr_RSL_MsgTypeC(?), sid := ?)) -> value rx_rsl { - if (not bts_role and mp_rslem_patch_ipa_cid) { - f_trx_conn_map_patch_ud(rx_rsl); - } CCHAN_PT.send(rx_rsl); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I39e9c1986ea682d54dcb22b31798ca91f1677949 Gerrit-Change-Number: 23117 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210226/bdde4db2/attachment.htm>