<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23117">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">RSL_Emulation: Get rid of module param mp_rslem_patch_ipa_cid<br><br>This param is not needed anymore since new releases used in -latest don't<br>need to disable it.<br><br>Change-Id: I39e9c1986ea682d54dcb22b31798ca91f1677949<br>Related: OS#5042<br>---<br>M library/RSL_Emulation.ttcn<br>1 file changed, 0 insertions(+), 22 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/23117/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn</span><br><span>index 0a20459..f436c66 100644</span><br><span>--- a/library/RSL_Emulation.ttcn</span><br><span>+++ b/library/RSL_Emulation.ttcn</span><br><span>@@ -36,9 +36,6 @@</span><br><span> </span><br><span> </span><br><span> modulepar {</span><br><span style="color: hsl(0, 100%, 40%);">-    /* Work around switch for ttcn3-bts-test-latest, enables patching of IPA</span><br><span style="color: hsl(0, 100%, 40%);">-         * stream ID in the "BSC" mode. See I5927f59a49724170a63e87be604973f7c9d5d8be. */</span><br><span style="color: hsl(0, 100%, 40%);">-     boolean mp_rslem_patch_ipa_cid := false;</span><br><span> };</span><br><span> </span><br><span> /* General "base class" component definition, of which specific implementations</span><br><span>@@ -419,19 +416,6 @@</span><br><span>       return TrxConnMap[trx_nr];</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Work around for a bug in osmo-bts when all transceivers use IPAC_PROTO_RSL_TRX0 */</span><br><span style="color: hsl(0, 100%, 40%);">-private function f_trx_conn_map_patch_ud(inout ASP_RSL_Unitdata ud)</span><br><span style="color: hsl(0, 100%, 40%);">-runs on RSL_Emulation_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-   for (var integer i := 0; i < sizeof(TrxConnMap); i := i + 1) {</span><br><span style="color: hsl(0, 100%, 40%);">-               if (ud.conn_id == TrxConnMap[i]) {</span><br><span style="color: hsl(0, 100%, 40%);">-                      ud.streamId := f_streamId_by_trx(i);</span><br><span style="color: hsl(0, 100%, 40%);">-                    return; /* We're done */</span><br><span style="color: hsl(0, 100%, 40%);">-            }</span><br><span style="color: hsl(0, 100%, 40%);">-       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       testcase.stop("Failed to patch IPA stream ID in ASP RSL UD: ", ud);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> private type record of ASP_RSL_Unitdata ASP_RSL_UDList;</span><br><span> </span><br><span> type component RSL_Emulation_CT {</span><br><span>@@ -587,17 +571,11 @@</span><br><span> </span><br><span>               /* Forward common channel management to the special port for it */</span><br><span>           [] IPA_PT.receive(tr_ASP_RSL_UD(tr_RSL_MsgTypeT(?), sid := ?)) -> value rx_rsl {</span><br><span style="color: hsl(0, 100%, 40%);">-                     if (not bts_role and mp_rslem_patch_ipa_cid) {</span><br><span style="color: hsl(0, 100%, 40%);">-                          f_trx_conn_map_patch_ud(rx_rsl);</span><br><span style="color: hsl(0, 100%, 40%);">-                        }</span><br><span>                    CCHAN_PT.send(rx_rsl);</span><br><span>               }</span><br><span> </span><br><span>                /* Forward common channel management to the special port for it */</span><br><span>           [] IPA_PT.receive(tr_ASP_RSL_UD(tr_RSL_MsgTypeC(?), sid := ?)) -> value rx_rsl {</span><br><span style="color: hsl(0, 100%, 40%);">-                     if (not bts_role and mp_rslem_patch_ipa_cid) {</span><br><span style="color: hsl(0, 100%, 40%);">-                          f_trx_conn_map_patch_ud(rx_rsl);</span><br><span style="color: hsl(0, 100%, 40%);">-                        }</span><br><span>                    CCHAN_PT.send(rx_rsl);</span><br><span>               }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23117">change 23117</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23117"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I39e9c1986ea682d54dcb22b31798ca91f1677949 </div>
<div style="display:none"> Gerrit-Change-Number: 23117 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>