Change in openbsc[master]: tests: Explicitly drop category from log

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Feb 22 10:38:22 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/openbsc/+/22990 )

Change subject: tests: Explicitly drop category from log
......................................................................

tests: Explicitly drop category from log

Let's disable category here since we don't care about its formatting here.

In any case, every test relying on logging output validation should
always explicitly state the config to avoid issues in the future if
default values change.

Change-Id: I2697ec547468019a544b66daf9dbb58aa8d9772b
Related: OS#5034
---
M openbsc/tests/db/db_test.c
M openbsc/tests/smpp/smpp_test.c
M openbsc/tests/subscr/bsc_subscr_test.c
M openbsc/tests/subscr/subscr_test.c
4 files changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/openbsc/tests/db/db_test.c b/openbsc/tests/db/db_test.c
index 3d44930..5742b43 100644
--- a/openbsc/tests/db/db_test.c
+++ b/openbsc/tests/db/db_test.c
@@ -207,6 +207,8 @@
 	osmo_init_logging(&log_info);
 	log_set_print_filename(osmo_stderr_target, 0);
 	log_set_use_color(osmo_stderr_target, 0);
+	log_set_print_category(osmo_stderr_target, 0);
+	log_set_print_category_hex(osmo_stderr_target, 0);
 
 	dummy_net.subscr_group = &dummy_sgrp;
 	dummy_sgrp.net         = &dummy_net;
diff --git a/openbsc/tests/smpp/smpp_test.c b/openbsc/tests/smpp/smpp_test.c
index 62fa9d2..e1e9a8b 100644
--- a/openbsc/tests/smpp/smpp_test.c
+++ b/openbsc/tests/smpp/smpp_test.c
@@ -67,6 +67,8 @@
 	osmo_init_logging(&log_info);
 	log_set_use_color(osmo_stderr_target, 0);
 	log_set_print_filename(osmo_stderr_target, 0);
+	log_set_print_category(osmo_stderr_target, 0);
+	log_set_print_category_hex(osmo_stderr_target, 0);
 
 	test_coding_scheme();
 	return EXIT_SUCCESS;
diff --git a/openbsc/tests/subscr/bsc_subscr_test.c b/openbsc/tests/subscr/bsc_subscr_test.c
index 60d687d..20ce07d 100644
--- a/openbsc/tests/subscr/bsc_subscr_test.c
+++ b/openbsc/tests/subscr/bsc_subscr_test.c
@@ -118,6 +118,7 @@
 	log_set_print_timestamp(osmo_stderr_target, 0);
 	log_set_use_color(osmo_stderr_target, 0);
 	log_set_print_category(osmo_stderr_target, 1);
+	log_set_print_category_hex(osmo_stderr_target, 0);
 	log_set_category_filter(osmo_stderr_target, DREF, 1, LOGL_DEBUG);
 
 	bsc_subscribers = talloc_zero(NULL, struct llist_head);
diff --git a/openbsc/tests/subscr/subscr_test.c b/openbsc/tests/subscr/subscr_test.c
index 2a5d0e1..78fa7bb 100644
--- a/openbsc/tests/subscr/subscr_test.c
+++ b/openbsc/tests/subscr/subscr_test.c
@@ -106,6 +106,8 @@
 	printf("Testing subscriber core code.\n");
 	osmo_init_logging(&log_info);
 	log_set_print_filename(osmo_stderr_target, 0);
+	log_set_print_category(osmo_stderr_target, 0);
+	log_set_print_category_hex(osmo_stderr_target, 0);
 
 	dummy_net.subscr_group = &dummy_sgrp;
 	dummy_sgrp.net         = &dummy_net;

-- 
To view, visit https://gerrit.osmocom.org/c/openbsc/+/22990
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Change-Id: I2697ec547468019a544b66daf9dbb58aa8d9772b
Gerrit-Change-Number: 22990
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210222/2044adfa/attachment.htm>


More information about the gerrit-log mailing list