<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/openbsc/+/22990">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests: Explicitly drop category from log<br><br>Let's disable category here since we don't care about its formatting here.<br><br>In any case, every test relying on logging output validation should<br>always explicitly state the config to avoid issues in the future if<br>default values change.<br><br>Change-Id: I2697ec547468019a544b66daf9dbb58aa8d9772b<br>Related: OS#5034<br>---<br>M openbsc/tests/db/db_test.c<br>M openbsc/tests/smpp/smpp_test.c<br>M openbsc/tests/subscr/bsc_subscr_test.c<br>M openbsc/tests/subscr/subscr_test.c<br>4 files changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/openbsc/tests/db/db_test.c b/openbsc/tests/db/db_test.c</span><br><span>index 3d44930..5742b43 100644</span><br><span>--- a/openbsc/tests/db/db_test.c</span><br><span>+++ b/openbsc/tests/db/db_test.c</span><br><span>@@ -207,6 +207,8 @@</span><br><span>      osmo_init_logging(&log_info);</span><br><span>    log_set_print_filename(osmo_stderr_target, 0);</span><br><span>       log_set_use_color(osmo_stderr_target, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+     log_set_print_category(osmo_stderr_target, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+        log_set_print_category_hex(osmo_stderr_target, 0);</span><br><span> </span><br><span>       dummy_net.subscr_group = &dummy_sgrp;</span><br><span>    dummy_sgrp.net         = &dummy_net;</span><br><span>diff --git a/openbsc/tests/smpp/smpp_test.c b/openbsc/tests/smpp/smpp_test.c</span><br><span>index 62fa9d2..e1e9a8b 100644</span><br><span>--- a/openbsc/tests/smpp/smpp_test.c</span><br><span>+++ b/openbsc/tests/smpp/smpp_test.c</span><br><span>@@ -67,6 +67,8 @@</span><br><span>    osmo_init_logging(&log_info);</span><br><span>    log_set_use_color(osmo_stderr_target, 0);</span><br><span>    log_set_print_filename(osmo_stderr_target, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+        log_set_print_category(osmo_stderr_target, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+        log_set_print_category_hex(osmo_stderr_target, 0);</span><br><span> </span><br><span>       test_coding_scheme();</span><br><span>        return EXIT_SUCCESS;</span><br><span>diff --git a/openbsc/tests/subscr/bsc_subscr_test.c b/openbsc/tests/subscr/bsc_subscr_test.c</span><br><span>index 60d687d..20ce07d 100644</span><br><span>--- a/openbsc/tests/subscr/bsc_subscr_test.c</span><br><span>+++ b/openbsc/tests/subscr/bsc_subscr_test.c</span><br><span>@@ -118,6 +118,7 @@</span><br><span>      log_set_print_timestamp(osmo_stderr_target, 0);</span><br><span>      log_set_use_color(osmo_stderr_target, 0);</span><br><span>    log_set_print_category(osmo_stderr_target, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+        log_set_print_category_hex(osmo_stderr_target, 0);</span><br><span>   log_set_category_filter(osmo_stderr_target, DREF, 1, LOGL_DEBUG);</span><br><span> </span><br><span>        bsc_subscribers = talloc_zero(NULL, struct llist_head);</span><br><span>diff --git a/openbsc/tests/subscr/subscr_test.c b/openbsc/tests/subscr/subscr_test.c</span><br><span>index 2a5d0e1..78fa7bb 100644</span><br><span>--- a/openbsc/tests/subscr/subscr_test.c</span><br><span>+++ b/openbsc/tests/subscr/subscr_test.c</span><br><span>@@ -106,6 +106,8 @@</span><br><span>   printf("Testing subscriber core code.\n");</span><br><span>         osmo_init_logging(&log_info);</span><br><span>    log_set_print_filename(osmo_stderr_target, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+        log_set_print_category(osmo_stderr_target, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+        log_set_print_category_hex(osmo_stderr_target, 0);</span><br><span> </span><br><span>       dummy_net.subscr_group = &dummy_sgrp;</span><br><span>    dummy_sgrp.net         = &dummy_net;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/openbsc/+/22990">change 22990</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/openbsc/+/22990"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: openbsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2697ec547468019a544b66daf9dbb58aa8d9772b </div>
<div style="display:none"> Gerrit-Change-Number: 22990 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>