Change in libosmocore[master]: gsm_08_59, gsm_44_004: add struct for l1 information

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Feb 16 18:03:58 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22932 )

Change subject: gsm_08_59, gsm_44_004: add struct for l1 information
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/22932/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/22932/1//COMMIT_MSG@1 
PS1, Line 1: Parent:     52489850 (gsm: Fix encoding of gsm0808_cell_id_list2 with CGI-PS types)
> so it's neither the endianness, nor the bit-order that changes. […]
Huh, you forgot that amazing comment from src/common/l1sap.c?

  Some brilliant engineer decided that the ordering of fields on the Um interface is different from the order of fields in RSL. See 3GPP TS 44.004 (section 7.2) vs. 3GPP TS 48.058 (section 9.3.10).


https://gerrit.osmocom.org/c/libosmocore/+/22932/1/include/osmocom/gsm/protocol/gsm_44_004.h 
File include/osmocom/gsm/protocol/gsm_44_004.h:

https://gerrit.osmocom.org/c/libosmocore/+/22932/1/include/osmocom/gsm/protocol/gsm_44_004.h@17 
PS1, Line 17: 	
ws?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22932
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I23c1890b89d5a0574eb05dace9f64cc59d6f6df7
Gerrit-Change-Number: 22932
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Feb 2021 18:03:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210216/fc4e2c1c/attachment.htm>


More information about the gerrit-log mailing list