<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22932">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22932/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22932/1//COMMIT_MSG@1">Patch Set #1, Line 1:</a> <code style="font-family:monospace,monospace">Parent:     52489850 (gsm: Fix encoding of gsm0808_cell_id_list2 with CGI-PS types)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">so it's neither the endianness, nor the bit-order that changes. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Huh, you forgot that amazing comment from src/common/l1sap.c?</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  Some brilliant engineer decided that the ordering of fields on the Um interface is different from the order of fields in RSL. See 3GPP TS 44.004 (section 7.2) vs. 3GPP TS 48.058 (section 9.3.10).</pre></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22932/1/include/osmocom/gsm/protocol/gsm_44_004.h">File include/osmocom/gsm/protocol/gsm_44_004.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22932/1/include/osmocom/gsm/protocol/gsm_44_004.h@17">Patch Set #1, Line 17:</a> <code style="font-family:monospace,monospace">        </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ws?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22932">change 22932</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22932"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I23c1890b89d5a0574eb05dace9f64cc59d6f6df7 </div>
<div style="display:none"> Gerrit-Change-Number: 22932 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 16 Feb 2021 18:03:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>