Change in libosmocore[master]: gprs_ns2: inform the NS user (BSSGP) about the MTU of a NSE

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22343 )

Change subject: gprs_ns2: inform the NS user (BSSGP) about the MTU of a NSE
......................................................................


Patch Set 11:

(6 comments)

https://gerrit.osmocom.org/c/libosmocore/+/22343/11/include/osmocom/gprs/frame_relay.h 
File include/osmocom/gprs/frame_relay.h:

https://gerrit.osmocom.org/c/libosmocore/+/22343/11/include/osmocom/gprs/frame_relay.h@45 
PS11, Line 45: #define FRAME_RELAY_SDU FRAME_RELAY_MTU - 2
()


https://gerrit.osmocom.org/c/libosmocore/+/22343/11/src/gb/gprs_ns2.c 
File src/gb/gprs_ns2.c:

https://gerrit.osmocom.org/c/libosmocore/+/22343/11/src/gb/gprs_ns2.c@a468 
PS11, Line 468: 
non related


https://gerrit.osmocom.org/c/libosmocore/+/22343/11/src/gb/gprs_ns2.c@501 
PS11, Line 501: 		nsp.u.status.mtu = nse->mtu - 4; /* 1b NS PDU type, 1b NS SDU control, 2b BVCI */
B, not b? (byte vs bit)
Don't we have any header struct for this set of contents, where one can use sizeof()?


https://gerrit.osmocom.org/c/libosmocore/+/22343/11/src/gb/gprs_ns2.c@754 
PS11, Line 754: 	nse->mtu = 0;
not really needed since we use talloc_zero.


https://gerrit.osmocom.org/c/libosmocore/+/22343/11/src/gb/gprs_ns2_udp.c 
File src/gb/gprs_ns2_udp.c:

https://gerrit.osmocom.org/c/libosmocore/+/22343/11/src/gb/gprs_ns2_udp.c@a116 
PS11, Line 116: 
non-related


https://gerrit.osmocom.org/c/libosmocore/+/22343/11/tests/gb/gprs_ns2_test.c 
File tests/gb/gprs_ns2_test.c:

https://gerrit.osmocom.org/c/libosmocore/+/22343/11/tests/gb/gprs_ns2_test.c@43 
PS11, Line 43: static struct osmo_gprs_ns2_prim last_nse_recovery = {};
not important, but no need for = {} in a static var (it is already initializer to 0).



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22343
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5016b295db6185ec131d83089cf6c806e34ef1b6
Gerrit-Change-Number: 22343
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 15 Feb 2021 10:13:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210215/3e1539d4/attachment.htm>