Change in libosmocore[master]: gprs_ns2: inform the NS user (BSSGP) about the MTU of a NSE

[lynxis lazus]

lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22343 )

Change subject: gprs_ns2: inform the NS user (BSSGP) about the MTU of a NSE
......................................................................


Patch Set 11:

(4 comments)

https://gerrit.osmocom.org/c/libosmocore/+/22343/9/src/gb/gprs_ns2_fr.c 
File src/gb/gprs_ns2_fr.c:

https://gerrit.osmocom.org/c/libosmocore/+/22343/9/src/gb/gprs_ns2_fr.c@804 
PS9, Line 804: /* 48.016 § 6.1.4.2 default maximum information field size of 1600 octets
             : 	 * FR has 2 byte header */
             : 	bind->mtu = 1600 - 2;
> I think the "information field" is what comes after the header, so (without checking the specs again […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/22343/2/src/gb/gprs_ns2_frgre.c 
File src/gb/gprs_ns2_frgre.c:

https://gerrit.osmocom.org/c/libosmocore/+/22343/2/src/gb/gprs_ns2_frgre.c@572 
PS2, Line 572: 1500
> I think this changes from current behavior. […]
Ack


https://gerrit.osmocom.org/c/libosmocore/+/22343/9/src/gb/gprs_ns2_frgre.c 
File src/gb/gprs_ns2_frgre.c:

https://gerrit.osmocom.org/c/libosmocore/+/22343/9/src/gb/gprs_ns2_frgre.c@577 
PS9, Line 577: 	bind->mtu = 1600 - 2;
> same here. Also, probably worth adding a #define in the frame_relay. […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/22343/2/src/gb/gprs_ns2_internal.h 
File src/gb/gprs_ns2_internal.h:

https://gerrit.osmocom.org/c/libosmocore/+/22343/2/src/gb/gprs_ns2_internal.h@240 
PS2, Line 240: 
> is there a reason to use a signed value? like negative having  a special meaning? If yes, please doc […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22343
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5016b295db6185ec131d83089cf6c806e34ef1b6
Gerrit-Change-Number: 22343
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 15 Feb 2021 04:31:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210215/8ef9422b/attachment.htm>