Change in libosmocore[master]: BVC FSM: Treat overlapping BVC-RESET as implicit ACK

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Mon Feb 15 10:06:55 UTC 2021


daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22895 )

Change subject: BVC FSM: Treat overlapping BVC-RESET as implicit ACK
......................................................................

BVC FSM: Treat overlapping BVC-RESET as implicit ACK

If the BSS (or SGSN) has sent a BVC-RESET PDU for a BVCI to the SGSN (or
BSS) and is awaiting a BVC-RESET- ACK PDU in response, but instead
receives a BVC-RESET PDU indicating the same BVCI, then this shall be
interpreted as a BVC-RESET ACK PDU and the T2 timer shall be stopped.

Related: OS#4974
Change-Id: I4d15733f9f205cb563b66ef9e41dc8df50151900
---
M src/gb/bssgp_bvc_fsm.c
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  daniel: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gb/bssgp_bvc_fsm.c b/src/gb/bssgp_bvc_fsm.c
index 8d284d1..ce9079d 100644
--- a/src/gb/bssgp_bvc_fsm.c
+++ b/src/gb/bssgp_bvc_fsm.c
@@ -377,6 +377,12 @@
 	struct msgb *rx = NULL, *tx;
 
 	switch (event) {
+	case BSSGP_BVCFSM_E_RX_RESET:
+		/* 48.018 Section 8.4.3: If the BSS (or SGSN) has sent a BVC-RESET PDU for a BVCI to
+		 * the SGSN (or BSS) and is awaiting a BVC-RESET-ACK PDU in response, but instead
+		 * receives a BVC-RESET PDU indicating the same BVCI, then this shall be interpreted
+		 * as a BVC-RESET ACK PDU and the T2 timer shall be stopped. */
+		/* fall-through */
 	case BSSGP_BVCFSM_E_RX_RESET_ACK:
 		rx = data;
 		tp = (const struct tlv_parsed *) msgb_bcid(rx);
@@ -606,7 +612,8 @@
 	},
 	[BSSGP_BVCFSM_S_WAIT_RESET_ACK]= {
 		.name = "WAIT_RESET_ACK",
-		.in_event_mask = S(BSSGP_BVCFSM_E_RX_RESET_ACK),
+		.in_event_mask = S(BSSGP_BVCFSM_E_RX_RESET_ACK) |
+				 S(BSSGP_BVCFSM_E_RX_RESET),
 		.out_state_mask = S(BSSGP_BVCFSM_S_UNBLOCKED) |
 				  S(BSSGP_BVCFSM_S_BLOCKED) |
 				  S(BSSGP_BVCFSM_S_WAIT_RESET_ACK),

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22895
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4d15733f9f205cb563b66ef9e41dc8df50151900
Gerrit-Change-Number: 22895
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210215/b13a0cec/attachment.htm>


More information about the gerrit-log mailing list