<p>daniel <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22895">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  daniel: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BVC FSM: Treat overlapping BVC-RESET as implicit ACK<br><br>If the BSS (or SGSN) has sent a BVC-RESET PDU for a BVCI to the SGSN (or<br>BSS) and is awaiting a BVC-RESET- ACK PDU in response, but instead<br>receives a BVC-RESET PDU indicating the same BVCI, then this shall be<br>interpreted as a BVC-RESET ACK PDU and the T2 timer shall be stopped.<br><br>Related: OS#4974<br>Change-Id: I4d15733f9f205cb563b66ef9e41dc8df50151900<br>---<br>M src/gb/bssgp_bvc_fsm.c<br>1 file changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/bssgp_bvc_fsm.c b/src/gb/bssgp_bvc_fsm.c</span><br><span>index 8d284d1..ce9079d 100644</span><br><span>--- a/src/gb/bssgp_bvc_fsm.c</span><br><span>+++ b/src/gb/bssgp_bvc_fsm.c</span><br><span>@@ -377,6 +377,12 @@</span><br><span>     struct msgb *rx = NULL, *tx;</span><br><span> </span><br><span>     switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+      case BSSGP_BVCFSM_E_RX_RESET:</span><br><span style="color: hsl(120, 100%, 40%);">+         /* 48.018 Section 8.4.3: If the BSS (or SGSN) has sent a BVC-RESET PDU for a BVCI to</span><br><span style="color: hsl(120, 100%, 40%);">+           * the SGSN (or BSS) and is awaiting a BVC-RESET-ACK PDU in response, but instead</span><br><span style="color: hsl(120, 100%, 40%);">+              * receives a BVC-RESET PDU indicating the same BVCI, then this shall be interpreted</span><br><span style="color: hsl(120, 100%, 40%);">+           * as a BVC-RESET ACK PDU and the T2 timer shall be stopped. */</span><br><span style="color: hsl(120, 100%, 40%);">+               /* fall-through */</span><br><span>   case BSSGP_BVCFSM_E_RX_RESET_ACK:</span><br><span>            rx = data;</span><br><span>           tp = (const struct tlv_parsed *) msgb_bcid(rx);</span><br><span>@@ -606,7 +612,8 @@</span><br><span>        },</span><br><span>   [BSSGP_BVCFSM_S_WAIT_RESET_ACK]= {</span><br><span>           .name = "WAIT_RESET_ACK",</span><br><span style="color: hsl(0, 100%, 40%);">-             .in_event_mask = S(BSSGP_BVCFSM_E_RX_RESET_ACK),</span><br><span style="color: hsl(120, 100%, 40%);">+              .in_event_mask = S(BSSGP_BVCFSM_E_RX_RESET_ACK) |</span><br><span style="color: hsl(120, 100%, 40%);">+                              S(BSSGP_BVCFSM_E_RX_RESET),</span><br><span>                 .out_state_mask = S(BSSGP_BVCFSM_S_UNBLOCKED) |</span><br><span>                                S(BSSGP_BVCFSM_S_BLOCKED) |</span><br><span>                                  S(BSSGP_BVCFSM_S_WAIT_RESET_ACK),</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22895">change 22895</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22895"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4d15733f9f205cb563b66ef9e41dc8df50151900 </div>
<div style="display:none"> Gerrit-Change-Number: 22895 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>