Change in osmo-bts[master]: l1sap.c: be sure that FACCH repetition is turned off

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/22861 )


Change subject: l1sap.c: be sure that FACCH repetition is turned off
......................................................................

l1sap.c: be sure that FACCH repetition is turned off

At the beginning of repeated_dl_facch_active_decision() the ACCH
repetition capabilitiy flags (command only or all LAPDM frames) are
tested. If no FACCH repetition is enabled, the function exists. However,
we should also make sure that the struct memeber that enables FACCH
repetition on the lower level is set to false as well. Normally that
should be the case because it was never set to true before, but it is
better to be sure.

Change-Id: Id07091cc89352281b41532d583a8bc004477c71a
Related: SYS#5114
---
M src/common/l1sap.c
1 file changed, 7 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/61/22861/1

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index b6970f4..3de76ab 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -980,9 +980,15 @@
 	uint8_t lower;
 	uint8_t rxqual;
 
+	/* This is an optimization so that we exit as quickly as possible if
+	 * there are no FACCH repetition capabilities present. However If the
+	 * repeated FACCH capabilities vanish for whatever reason, we must be
+	 * sure that FACCH repetition is disabled. */
 	if (!lchan->repeated_acch_capability.dl_facch_cmd
-	    && !lchan->repeated_acch_capability.dl_facch_all)
+	    && !lchan->repeated_acch_capability.dl_facch_all) {
+		lchan->repeated_dl_facch_active = false;
 		return;
+	}
 
 	/* Threshold disabled (always on) */
 	if (lchan->repeated_acch_capability.rxqual == 0) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22861
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id07091cc89352281b41532d583a8bc004477c71a
Gerrit-Change-Number: 22861
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210211/ace06dc0/attachment.htm>