<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/22861">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">l1sap.c: be sure that FACCH repetition is turned off<br><br>At the beginning of repeated_dl_facch_active_decision() the ACCH<br>repetition capabilitiy flags (command only or all LAPDM frames) are<br>tested. If no FACCH repetition is enabled, the function exists. However,<br>we should also make sure that the struct memeber that enables FACCH<br>repetition on the lower level is set to false as well. Normally that<br>should be the case because it was never set to true before, but it is<br>better to be sure.<br><br>Change-Id: Id07091cc89352281b41532d583a8bc004477c71a<br>Related: SYS#5114<br>---<br>M src/common/l1sap.c<br>1 file changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/61/22861/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index b6970f4..3de76ab 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -980,9 +980,15 @@</span><br><span>    uint8_t lower;</span><br><span>       uint8_t rxqual;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   /* This is an optimization so that we exit as quickly as possible if</span><br><span style="color: hsl(120, 100%, 40%);">+   * there are no FACCH repetition capabilities present. However If the</span><br><span style="color: hsl(120, 100%, 40%);">+  * repeated FACCH capabilities vanish for whatever reason, we must be</span><br><span style="color: hsl(120, 100%, 40%);">+  * sure that FACCH repetition is disabled. */</span><br><span>        if (!lchan->repeated_acch_capability.dl_facch_cmd</span><br><span style="color: hsl(0, 100%, 40%);">-        && !lchan->repeated_acch_capability.dl_facch_all)</span><br><span style="color: hsl(120, 100%, 40%);">+          && !lchan->repeated_acch_capability.dl_facch_all) {</span><br><span style="color: hsl(120, 100%, 40%);">+            lchan->repeated_dl_facch_active = false;</span><br><span>          return;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span> </span><br><span>        /* Threshold disabled (always on) */</span><br><span>         if (lchan->repeated_acch_capability.rxqual == 0) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/22861">change 22861</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/22861"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id07091cc89352281b41532d583a8bc004477c71a </div>
<div style="display:none"> Gerrit-Change-Number: 22861 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>