Change in osmo-gbproxy[master]: Various comment/whitespace changes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Wed Feb 10 12:44:57 UTC 2021


daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/22809 )


Change subject: Various comment/whitespace changes
......................................................................

Various comment/whitespace changes

Change-Id: I0eeef3ec16c249d65e9358889d21cc4984b7b51f
---
M src/gb_proxy.c
M src/gb_proxy_peer.c
2 files changed, 3 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/09/22809/1

diff --git a/src/gb_proxy.c b/src/gb_proxy.c
index 116530f..90f7bb7 100644
--- a/src/gb_proxy.c
+++ b/src/gb_proxy.c
@@ -461,7 +461,6 @@
 		} else if (TLVP_PRESENT(&tp, BSSGP_IE_IMSI)) {
 			/* FIXME: Use the IMSI as selector? */
 			rc = gbprox_bss2sgsn_tlli(bss_bvc->cell, msg, NULL, false);
-			/* rc = gbprox_bss2sgsn_hashed(bss_bvc->cell, msg, NULL); */
 		} else
 			LOGPBVC(bss_bvc, LOGL_ERROR, "Rx RADIO-STATUS without any of the conditional IEs\n");
 		break;
@@ -1392,7 +1391,7 @@
 			uint8_t cause = BSSGP_CAUSE_OML_INTERV;
 			bvc = gbproxy_bvc_by_bvci(sgsn_nse, 0);
 			if (bvc)
-				osmo_fsm_inst_dispatch(bvc->fi, BSSGP_BVCFSM_E_REQ_RESET, &cause); 
+				osmo_fsm_inst_dispatch(bvc->fi, BSSGP_BVCFSM_E_REQ_RESET, &cause);
 		}
 		break;
 	case GPRS_NS2_AFF_CAUSE_FAILURE:
diff --git a/src/gb_proxy_peer.c b/src/gb_proxy_peer.c
index 9ea00a9..27d73b8 100644
--- a/src/gb_proxy_peer.c
+++ b/src/gb_proxy_peer.c
@@ -93,8 +93,7 @@
 
 	/* We leave allocating the bvc->fi to the caller, as the FSM details depend
 	 * on the type of BVC (SIG/PTP) and role (SGSN/BSS) */
-
-        return bvc;
+	return bvc;
 }
 
 void gbproxy_bvc_free(struct gbproxy_bvc *bvc)
@@ -711,7 +710,7 @@
 	return NULL;
 }
 
-/*! Seleect a pseudo-random SGSN for a given TLLI, ignoring any SGSN that is not accepting connections
+/*! Select a pseudo-random SGSN for a given TLLI, ignoring any SGSN that is not accepting connections
  *  \param[in] cfg The gbproxy configuration
  *  \param[in] sgsn_avoid If not NULL then avoid this SGSN when selecting a new one. Use for load redistribution
  *  \param[in] tlli The tlli to choose an SGSN for. The same tlli will map to the same SGSN as long as no SGSN is

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/22809
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: I0eeef3ec16c249d65e9358889d21cc4984b7b51f
Gerrit-Change-Number: 22809
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210210/a62de28a/attachment.htm>


More information about the gerrit-log mailing list