<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/22809">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Various comment/whitespace changes<br><br>Change-Id: I0eeef3ec16c249d65e9358889d21cc4984b7b51f<br>---<br>M src/gb_proxy.c<br>M src/gb_proxy_peer.c<br>2 files changed, 3 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/09/22809/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb_proxy.c b/src/gb_proxy.c</span><br><span>index 116530f..90f7bb7 100644</span><br><span>--- a/src/gb_proxy.c</span><br><span>+++ b/src/gb_proxy.c</span><br><span>@@ -461,7 +461,6 @@</span><br><span>              } else if (TLVP_PRESENT(&tp, BSSGP_IE_IMSI)) {</span><br><span>                   /* FIXME: Use the IMSI as selector? */</span><br><span>                       rc = gbprox_bss2sgsn_tlli(bss_bvc->cell, msg, NULL, false);</span><br><span style="color: hsl(0, 100%, 40%);">-                  /* rc = gbprox_bss2sgsn_hashed(bss_bvc->cell, msg, NULL); */</span><br><span>              } else</span><br><span>                       LOGPBVC(bss_bvc, LOGL_ERROR, "Rx RADIO-STATUS without any of the conditional IEs\n");</span><br><span>              break;</span><br><span>@@ -1392,7 +1391,7 @@</span><br><span>                       uint8_t cause = BSSGP_CAUSE_OML_INTERV;</span><br><span>                      bvc = gbproxy_bvc_by_bvci(sgsn_nse, 0);</span><br><span>                      if (bvc)</span><br><span style="color: hsl(0, 100%, 40%);">-                                osmo_fsm_inst_dispatch(bvc->fi, BSSGP_BVCFSM_E_REQ_RESET, &cause); </span><br><span style="color: hsl(120, 100%, 40%);">+                            osmo_fsm_inst_dispatch(bvc->fi, BSSGP_BVCFSM_E_REQ_RESET, &cause);</span><br><span>            }</span><br><span>            break;</span><br><span>       case GPRS_NS2_AFF_CAUSE_FAILURE:</span><br><span>diff --git a/src/gb_proxy_peer.c b/src/gb_proxy_peer.c</span><br><span>index 9ea00a9..27d73b8 100644</span><br><span>--- a/src/gb_proxy_peer.c</span><br><span>+++ b/src/gb_proxy_peer.c</span><br><span>@@ -93,8 +93,7 @@</span><br><span> </span><br><span>    /* We leave allocating the bvc->fi to the caller, as the FSM details depend</span><br><span>        * on the type of BVC (SIG/PTP) and role (SGSN/BSS) */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-        return bvc;</span><br><span style="color: hsl(120, 100%, 40%);">+     return bvc;</span><br><span> }</span><br><span> </span><br><span> void gbproxy_bvc_free(struct gbproxy_bvc *bvc)</span><br><span>@@ -711,7 +710,7 @@</span><br><span>         return NULL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*! Seleect a pseudo-random SGSN for a given TLLI, ignoring any SGSN that is not accepting connections</span><br><span style="color: hsl(120, 100%, 40%);">+/*! Select a pseudo-random SGSN for a given TLLI, ignoring any SGSN that is not accepting connections</span><br><span>  *  \param[in] cfg The gbproxy configuration</span><br><span>  *  \param[in] sgsn_avoid If not NULL then avoid this SGSN when selecting a new one. Use for load redistribution</span><br><span>  *  \param[in] tlli The tlli to choose an SGSN for. The same tlli will map to the same SGSN as long as no SGSN is</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/22809">change 22809</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/22809"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gbproxy </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0eeef3ec16c249d65e9358889d21cc4984b7b51f </div>
<div style="display:none"> Gerrit-Change-Number: 22809 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>