Change in libosmocore[master]: gsm: Introduce API osmo_gsm48_rest_octets_si13_decode

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22800 )

Change subject: gsm: Introduce API osmo_gsm48_rest_octets_si13_decode
......................................................................


Patch Set 1:

(5 comments)

Would be also nice to have a unit test given that we already have the encoding function.

https://gerrit.osmocom.org/c/libosmocore/+/22800/1/src/gsm/gsm48_rest_octets.c 
File src/gsm/gsm48_rest_octets.c:

https://gerrit.osmocom.org/c/libosmocore/+/22800/1/src/gsm/gsm48_rest_octets.c@758 
PS1, Line 758: 	switch (t3192) {
Let's better use a lookup table here, it's only 8 elements in total...


https://gerrit.osmocom.org/c/libosmocore/+/22800/1/src/gsm/gsm48_rest_octets.c@775 
PS1, Line 775: 	switch (drx) {
Same here, use lookup table. Furthermore, you would not even need separate functions for that.


https://gerrit.osmocom.org/c/libosmocore/+/22800/1/src/gsm/gsm48_rest_octets.c@797 
PS1, Line 797: 	/* ACCESS_BURST_TYPE: */
add FIXME?


https://gerrit.osmocom.org/c/libosmocore/+/22800/1/src/gsm/gsm48_rest_octets.c@861 
PS1, Line 861: -1
-ENOTSUPP?


https://gerrit.osmocom.org/c/libosmocore/+/22800/1/src/gsm/gsm48_rest_octets.c@866 
PS1, Line 866: 			return -1;
-ENOTSUPP?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22800
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I74fb0a3afc1ac4aadbfc609b882d929401f790eb
Gerrit-Change-Number: 22800
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Feb 2021 19:47:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210209/9e4afda3/attachment.htm>