<p style="white-space: pre-wrap; word-wrap: break-word;">Would be also nice to have a unit test given that we already have the encoding function.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22800">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22800/1/src/gsm/gsm48_rest_octets.c">File src/gsm/gsm48_rest_octets.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22800/1/src/gsm/gsm48_rest_octets.c@758">Patch Set #1, Line 758:</a> <code style="font-family:monospace,monospace">      switch (t3192) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Let's better use a lookup table here, it's only 8 elements in total...</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22800/1/src/gsm/gsm48_rest_octets.c@775">Patch Set #1, Line 775:</a> <code style="font-family:monospace,monospace">     switch (drx) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here, use lookup table. Furthermore, you would not even need separate functions for that.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22800/1/src/gsm/gsm48_rest_octets.c@797">Patch Set #1, Line 797:</a> <code style="font-family:monospace,monospace">       /* ACCESS_BURST_TYPE: */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">add FIXME?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22800/1/src/gsm/gsm48_rest_octets.c@861">Patch Set #1, Line 861:</a> <code style="font-family:monospace,monospace">-1</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">-ENOTSUPP?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22800/1/src/gsm/gsm48_rest_octets.c@866">Patch Set #1, Line 866:</a> <code style="font-family:monospace,monospace">                        return -1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">-ENOTSUPP?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22800">change 22800</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22800"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I74fb0a3afc1ac4aadbfc609b882d929401f790eb </div>
<div style="display:none"> Gerrit-Change-Number: 22800 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 09 Feb 2021 19:47:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>