This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653 ) Change subject: gb_proxy: simplify raid data storage ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653/6/src/gb_proxy.c File src/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653/6/src/gb_proxy.c@674 PS6, Line 674: memcpy(&bvc->cell->id.raid, &bvc->id.raid, sizeof(bvc->cell->id.raid)); > Shouldn't we use ra_id here and also copy ra_id to bvc->id.raid in the beginning of the function? […] The current version also uses the value from bvc->cell, I think we should keep everything equivalent in this patch to avoid running into unexpected behavior changes again. I can not say if the parameter ra_id should be used here. I do not know the project well enough to estimate the behavior change. If you still want to have this changed, lets do this after we are through with the RIM integration. -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ib58b9188e3ce4bd3fdadb03f158d56b29778387c Gerrit-Change-Number: 22653 Gerrit-PatchSet: 6 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 09 Feb 2021 11:30:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210209/7773fd7d/attachment.htm>