Change in osmo-gbproxy[master]: gb_proxy: simplify raid data storage

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Thu Feb 4 21:33:04 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653 )

Change subject: gb_proxy: simplify raid data storage
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653/6/src/gb_proxy.c 
File src/gb_proxy.c:

https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653/6/src/gb_proxy.c@674 
PS6, Line 674: 		memcpy(&bvc->cell->id.raid, &bvc->id.raid, sizeof(bvc->cell->id.raid));
Shouldn't we use ra_id here and also copy ra_id to bvc->id.raid in the beginning of the function?

I think then we can get rid of the FIXME below.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: Ib58b9188e3ce4bd3fdadb03f158d56b29778387c
Gerrit-Change-Number: 22653
Gerrit-PatchSet: 6
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 04 Feb 2021 21:33:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210204/7d3b763a/attachment.htm>


More information about the gerrit-log mailing list