Change in osmo-gsm-tester[master]: enb, epc: implement stdout/log KPI getter in eNB/EPC base class

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601 )

Change subject: enb,epc: implement stdout/log KPI getter in eNB/EPC base class
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/3/src/osmo_gsm_tester/obj/enb.py 
File src/osmo_gsm_tester/obj/enb.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/3/src/osmo_gsm_tester/obj/enb.py@360 
PS3, Line 360:     def get_stdout_kpis(self):
As I said, I'm not really liking more and more APIS appearing. I don't see the benefit of having several APIs where one "get_kpis" containing all the kpis (dict) is enough.


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/3/src/osmo_gsm_tester/obj/epc.py 
File src/osmo_gsm_tester/obj/epc.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/3/src/osmo_gsm_tester/obj/epc.py@124 
PS3, Line 124:         return {'total_errors': 0, 'total_warnings': 0}        
Still missing to remove trailing whitespace.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I7c6c9abf73c2fc1d9104ea082bef6ffa0aeeac32
Gerrit-Change-Number: 22601
Gerrit-PatchSet: 3
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Feb 2021 17:02:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210208/11d72538/attachment.htm>