Change in osmo-gsm-tester[master]: enb, epc: implement stdout/log KPI getter in eNB/EPC base class

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

srs_andre gerrit-no-reply at lists.osmocom.org
Mon Feb 8 16:32:12 UTC 2021


srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601 )

Change subject: enb,epc: implement stdout/log KPI getter in eNB/EPC base class
......................................................................


Patch Set 2:

(3 comments)

See below, thanks

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py 
File src/osmo_gsm_tester/obj/enb.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py@358 
PS1, Line 358:     
> Remove this whitespace
Ack


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py@364 
PS1, Line 364:     def get_log_kpis(self):
> I'm not sure what's the point in splitting between log and kpi, is there some rationale behind this?
the idea is that we have some KPI that we always get from stdout (like when a UE connects) and some that we get from the logs, but only if the log level is set accordingly


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py@368 
PS1, Line 368:     def get_num_phy_errors(self, kpi):
> What about this function? looks not related to this patch?
It's used in one of the TC to check for erros, like also KPI. We never ran the tests with Amarisoft eNB, so I didn't see it was an issue there. So now I've moved the method to enb.py



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I7c6c9abf73c2fc1d9104ea082bef6ffa0aeeac32
Gerrit-Change-Number: 22601
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Feb 2021 16:32:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210208/9bc6ca71/attachment.htm>


More information about the gerrit-log mailing list