Change in libosmocore[master]: ns2: Name NSVC FSM events consistently

[laforge]

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/22734 )


Change subject: ns2: Name NSVC FSM events consistently
......................................................................

ns2: Name NSVC FSM events consistently

Reading a log line like this:

<0026> gprs_ns2_vc_fsm.c:808 GPRS-NS2-VC(FR-hdlcnet1-DLCI16-NSE02001-NSVC00001)[0x6120000024a0]{UNBLOCKED}: Received Event RESET

is very ambiguous. Does it mean we received a NS-RESET message? Does it
mean the FSM was instructed to send a NS-RESET? ...

Let's make sure the human-readable names give a very clear indication
of what exactly is happening.

Change-Id: I8b7615b3eca04212831163ff0ea4aea35069cd0e
---
M src/gb/gprs_ns2_vc_fsm.c
1 file changed, 12 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/34/22734/1

diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c
index f6424de..66ee450 100644
--- a/src/gb/gprs_ns2_vc_fsm.c
+++ b/src/gb/gprs_ns2_vc_fsm.c
@@ -122,18 +122,18 @@
 };
 
 static const struct value_string ns2_vc_event_names[] = {
-	{ GPRS_NS2_EV_REQ_START, 		"START" },
-	{ GPRS_NS2_EV_RX_RESET,			"RESET" },
-	{ GPRS_NS2_EV_RX_RESET_ACK,		"RESET_ACK" },
-	{ GPRS_NS2_EV_RX_UNBLOCK,		"UNBLOCK" },
-	{ GPRS_NS2_EV_RX_UNBLOCK_ACK,		"UNBLOCK_ACK" },
-	{ GPRS_NS2_EV_RX_BLOCK,			"BLOCK" },
-	{ GPRS_NS2_EV_RX_BLOCK_ACK,		"BLOCK_ACK" },
-	{ GPRS_NS2_EV_RX_ALIVE,			"ALIVE" },
-	{ GPRS_NS2_EV_RX_ALIVE_ACK,		"ALIVE_ACK" },
-	{ GPRS_NS2_EV_RX_STATUS,		"STATUS" },
-	{ GPRS_NS2_EV_RX_UNITDATA,		"UNITDATA" },
-	{ GPRS_NS2_EV_REQ_FORCE_UNCONFIGURED,	"FORCE_UNCONFIGURED" },
+	{ GPRS_NS2_EV_REQ_START, 		"REQ-START" },
+	{ GPRS_NS2_EV_RX_RESET,			"RX-RESET" },
+	{ GPRS_NS2_EV_RX_RESET_ACK,		"RX-RESET_ACK" },
+	{ GPRS_NS2_EV_RX_UNBLOCK,		"RX-UNBLOCK" },
+	{ GPRS_NS2_EV_RX_UNBLOCK_ACK,		"RX-UNBLOCK_ACK" },
+	{ GPRS_NS2_EV_RX_BLOCK,			"RX-BLOCK" },
+	{ GPRS_NS2_EV_RX_BLOCK_ACK,		"RX-BLOCK_ACK" },
+	{ GPRS_NS2_EV_RX_ALIVE,			"RX-ALIVE" },
+	{ GPRS_NS2_EV_RX_ALIVE_ACK,		"RX-ALIVE_ACK" },
+	{ GPRS_NS2_EV_RX_STATUS,		"RX-STATUS" },
+	{ GPRS_NS2_EV_RX_UNITDATA,		"RX-UNITDATA" },
+	{ GPRS_NS2_EV_REQ_FORCE_UNCONFIGURED,	"REQ-FORCE_UNCONFIGURED" },
 	{ GPRS_NS2_EV_REQ_OM_BLOCK,		"REQ-O&M-BLOCK"},
 	{ GPRS_NS2_EV_REQ_OM_UNBLOCK,		"REQ-O&M-UNBLOCK"},
 	{ 0, NULL }

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22734
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8b7615b3eca04212831163ff0ea4aea35069cd0e
Gerrit-Change-Number: 22734
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210205/9ff8bdb6/attachment.htm>