<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22734">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2: Name NSVC FSM events consistently<br><br>Reading a log line like this:<br><br><0026> gprs_ns2_vc_fsm.c:808 GPRS-NS2-VC(FR-hdlcnet1-DLCI16-NSE02001-NSVC00001)[0x6120000024a0]{UNBLOCKED}: Received Event RESET<br><br>is very ambiguous. Does it mean we received a NS-RESET message? Does it<br>mean the FSM was instructed to send a NS-RESET? ...<br><br>Let's make sure the human-readable names give a very clear indication<br>of what exactly is happening.<br><br>Change-Id: I8b7615b3eca04212831163ff0ea4aea35069cd0e<br>---<br>M src/gb/gprs_ns2_vc_fsm.c<br>1 file changed, 12 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/34/22734/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c</span><br><span>index f6424de..66ee450 100644</span><br><span>--- a/src/gb/gprs_ns2_vc_fsm.c</span><br><span>+++ b/src/gb/gprs_ns2_vc_fsm.c</span><br><span>@@ -122,18 +122,18 @@</span><br><span> };</span><br><span> </span><br><span> static const struct value_string ns2_vc_event_names[] = {</span><br><span style="color: hsl(0, 100%, 40%);">-  { GPRS_NS2_EV_REQ_START,                "START" },</span><br><span style="color: hsl(0, 100%, 40%);">-    { GPRS_NS2_EV_RX_RESET,                 "RESET" },</span><br><span style="color: hsl(0, 100%, 40%);">-    { GPRS_NS2_EV_RX_RESET_ACK,             "RESET_ACK" },</span><br><span style="color: hsl(0, 100%, 40%);">-        { GPRS_NS2_EV_RX_UNBLOCK,               "UNBLOCK" },</span><br><span style="color: hsl(0, 100%, 40%);">-  { GPRS_NS2_EV_RX_UNBLOCK_ACK,           "UNBLOCK_ACK" },</span><br><span style="color: hsl(0, 100%, 40%);">-      { GPRS_NS2_EV_RX_BLOCK,                 "BLOCK" },</span><br><span style="color: hsl(0, 100%, 40%);">-    { GPRS_NS2_EV_RX_BLOCK_ACK,             "BLOCK_ACK" },</span><br><span style="color: hsl(0, 100%, 40%);">-        { GPRS_NS2_EV_RX_ALIVE,                 "ALIVE" },</span><br><span style="color: hsl(0, 100%, 40%);">-    { GPRS_NS2_EV_RX_ALIVE_ACK,             "ALIVE_ACK" },</span><br><span style="color: hsl(0, 100%, 40%);">-        { GPRS_NS2_EV_RX_STATUS,                "STATUS" },</span><br><span style="color: hsl(0, 100%, 40%);">-   { GPRS_NS2_EV_RX_UNITDATA,              "UNITDATA" },</span><br><span style="color: hsl(0, 100%, 40%);">- { GPRS_NS2_EV_REQ_FORCE_UNCONFIGURED,   "FORCE_UNCONFIGURED" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { GPRS_NS2_EV_REQ_START,                "REQ-START" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { GPRS_NS2_EV_RX_RESET,                 "RX-RESET" },</span><br><span style="color: hsl(120, 100%, 40%);">+       { GPRS_NS2_EV_RX_RESET_ACK,             "RX-RESET_ACK" },</span><br><span style="color: hsl(120, 100%, 40%);">+   { GPRS_NS2_EV_RX_UNBLOCK,               "RX-UNBLOCK" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { GPRS_NS2_EV_RX_UNBLOCK_ACK,           "RX-UNBLOCK_ACK" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { GPRS_NS2_EV_RX_BLOCK,                 "RX-BLOCK" },</span><br><span style="color: hsl(120, 100%, 40%);">+       { GPRS_NS2_EV_RX_BLOCK_ACK,             "RX-BLOCK_ACK" },</span><br><span style="color: hsl(120, 100%, 40%);">+   { GPRS_NS2_EV_RX_ALIVE,                 "RX-ALIVE" },</span><br><span style="color: hsl(120, 100%, 40%);">+       { GPRS_NS2_EV_RX_ALIVE_ACK,             "RX-ALIVE_ACK" },</span><br><span style="color: hsl(120, 100%, 40%);">+   { GPRS_NS2_EV_RX_STATUS,                "RX-STATUS" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { GPRS_NS2_EV_RX_UNITDATA,              "RX-UNITDATA" },</span><br><span style="color: hsl(120, 100%, 40%);">+    { GPRS_NS2_EV_REQ_FORCE_UNCONFIGURED,   "REQ-FORCE_UNCONFIGURED" },</span><br><span>        { GPRS_NS2_EV_REQ_OM_BLOCK,             "REQ-O&M-BLOCK"},</span><br><span>      { GPRS_NS2_EV_REQ_OM_UNBLOCK,           "REQ-O&M-UNBLOCK"},</span><br><span>    { 0, NULL }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22734">change 22734</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22734"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8b7615b3eca04212831163ff0ea4aea35069cd0e </div>
<div style="display:none"> Gerrit-Change-Number: 22734 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>