Change in osmo-bts[master]: pcu_sock: fix uninitalized returncode value

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22677 )

Change subject: pcu_sock: fix uninitalized returncode value
......................................................................

pcu_sock: fix uninitalized returncode value

In function pcu_tx_si_all(), the variable rc is not initalized. If
pcu_tx_si() fails, then rc is populated with value -EINVAL, but if all
si transmissions succeed, which is the normal case, rc remains
uninitalized.

Change-Id: I571fdb4f175fb259b77f989554f569fc2230dfe6
Related: CID#216932
---
M src/common/pcu_sock.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 250491f..ec7f876 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -771,7 +771,7 @@
 	const enum osmo_sysinfo_type si_types[3] =
 	    { SYSINFO_TYPE_1, SYSINFO_TYPE_3, SYSINFO_TYPE_13 };
 	unsigned int i;
-	int rc;
+	int rc = 0;
 
 	for (i = 0; i < ARRAY_SIZE(si_types); i++) {
 		if (GSM_BTS_HAS_SI(bts, si_types[i])) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22677
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I571fdb4f175fb259b77f989554f569fc2230dfe6
Gerrit-Change-Number: 22677
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210204/a10a7d7e/attachment.htm>