<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/22677">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu_sock: fix uninitalized returncode value<br><br>In function pcu_tx_si_all(), the variable rc is not initalized. If<br>pcu_tx_si() fails, then rc is populated with value -EINVAL, but if all<br>si transmissions succeed, which is the normal case, rc remains<br>uninitalized.<br><br>Change-Id: I571fdb4f175fb259b77f989554f569fc2230dfe6<br>Related: CID#216932<br>---<br>M src/common/pcu_sock.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c</span><br><span>index 250491f..ec7f876 100644</span><br><span>--- a/src/common/pcu_sock.c</span><br><span>+++ b/src/common/pcu_sock.c</span><br><span>@@ -771,7 +771,7 @@</span><br><span>   const enum osmo_sysinfo_type si_types[3] =</span><br><span>       { SYSINFO_TYPE_1, SYSINFO_TYPE_3, SYSINFO_TYPE_13 };</span><br><span>     unsigned int i;</span><br><span style="color: hsl(0, 100%, 40%);">- int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+       int rc = 0;</span><br><span> </span><br><span>      for (i = 0; i < ARRAY_SIZE(si_types); i++) {</span><br><span>              if (GSM_BTS_HAS_SI(bts, si_types[i])) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/22677">change 22677</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/22677"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I571fdb4f175fb259b77f989554f569fc2230dfe6 </div>
<div style="display:none"> Gerrit-Change-Number: 22677 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>