Change in osmo-gbproxy[master]: Add Function to get gbproxy cell by cell id

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Wed Feb 3 16:29:34 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/22652 )

Change subject: Add Function to get gbproxy cell by cell id
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-gbproxy/+/22652/2/src/gb_proxy_peer.c 
File src/gb_proxy_peer.c:

https://gerrit.osmocom.org/c/osmo-gbproxy/+/22652/2/src/gb_proxy_peer.c@215 
PS2, Line 215: 		if ((cell->id.cid == cid) && (!memcmp(&cell->id.raid, raid, sizeof(*raid)))) {
> be careful when memcomparing structures, I already had some issues using it with cgi_ps one (due to  […]
Ok, thanks. I was a bit unsure about that. Will write/use a compare function



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/22652
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: I3403736eed9d6819634c26db0b90393ac6f4416a
Gerrit-Change-Number: 22652
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Feb 2021 16:29:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210203/f030876e/attachment.htm>


More information about the gerrit-log mailing list