Change in osmo-gbproxy[master]: Add Function to get gbproxy cell by cell id

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/22652 )

Change subject: Add Function to get gbproxy cell by cell id
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-gbproxy/+/22652/2/src/gb_proxy_peer.c 
File src/gb_proxy_peer.c:

https://gerrit.osmocom.org/c/osmo-gbproxy/+/22652/2/src/gb_proxy_peer.c@215 
PS2, Line 215: 		if ((cell->id.cid == cid) && (!memcmp(&cell->id.raid, raid, sizeof(*raid)))) {
be careful when memcomparing structures, I already had some issues using it with cgi_ps one (due to padding bytes having uninitialized bytes).
I'd rather add a _cmp function for gprs_ra_id (see for osmo_cgi_ps_cmp as an example).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/22652
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: I3403736eed9d6819634c26db0b90393ac6f4416a
Gerrit-Change-Number: 22652
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Feb 2021 15:13:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210203/8b8f238c/attachment.htm>