Change in osmo-pcu[master]: ms: Free tbf after scheduling Tx Pkt Cell Change Continue

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Feb 1 15:27:18 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22604 )


Change subject: ms: Free tbf after scheduling Tx Pkt Cell Change Continue
......................................................................

ms: Free tbf after scheduling Tx Pkt Cell Change Continue

The TBF should be gone since upon reception of the message the MS
continues to cell reselection on the target cell.

3GPP TS 44.060:
"""
When the mobile station receives the PACKET CELL CHANGE ORDER or
the PACKET CELL CHANGE CONTINUE message the mobile station shall
transmit a PACKET CONTROL ACKNOWLEDGMENT message in the specified
uplink radio block if a valid RRBP field is received as part of the
message; the mobile station may then switch to a new cell.
"""

Related: SYS#4909
Change-Id: I7cc28922e71699598da0ef6eb90136a47d3c002f
---
M src/gprs_ms.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/04/22604/1

diff --git a/src/gprs_ms.c b/src/gprs_ms.c
index 8078b10..f85b035 100644
--- a/src/gprs_ms.c
+++ b/src/gprs_ms.c
@@ -962,6 +962,7 @@
 {
 	int rc;
 	struct nacc_ev_create_rlcmac_msg_ctx data_ctx;
+	bool finish_tbf = ms->nacc->fi->state == NACC_ST_TX_CELL_CHG_CONTINUE;
 
 	data_ctx.tbf = tbf;
 	data_ctx.msg = NULL;
@@ -969,5 +970,7 @@
 	rc = osmo_fsm_inst_dispatch(ms->nacc->fi, NACC_EV_CREATE_RLCMAC_MSG, &data_ctx);
 	if (rc != 0 || !data_ctx.msg)
 		return NULL;
+	if (finish_tbf)
+		tbf_free(tbf);
 	return data_ctx.msg;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22604
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7cc28922e71699598da0ef6eb90136a47d3c002f
Gerrit-Change-Number: 22604
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210201/845e8185/attachment.htm>


More information about the gerrit-log mailing list