<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/22604">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ms: Free tbf after scheduling Tx Pkt Cell Change Continue<br><br>The TBF should be gone since upon reception of the message the MS<br>continues to cell reselection on the target cell.<br><br>3GPP TS 44.060:<br>"""<br>When the mobile station receives the PACKET CELL CHANGE ORDER or<br>the PACKET CELL CHANGE CONTINUE message the mobile station shall<br>transmit a PACKET CONTROL ACKNOWLEDGMENT message in the specified<br>uplink radio block if a valid RRBP field is received as part of the<br>message; the mobile station may then switch to a new cell.<br>"""<br><br>Related: SYS#4909<br>Change-Id: I7cc28922e71699598da0ef6eb90136a47d3c002f<br>---<br>M src/gprs_ms.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/04/22604/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_ms.c b/src/gprs_ms.c</span><br><span>index 8078b10..f85b035 100644</span><br><span>--- a/src/gprs_ms.c</span><br><span>+++ b/src/gprs_ms.c</span><br><span>@@ -962,6 +962,7 @@</span><br><span> {</span><br><span>         int rc;</span><br><span>      struct nacc_ev_create_rlcmac_msg_ctx data_ctx;</span><br><span style="color: hsl(120, 100%, 40%);">+        bool finish_tbf = ms->nacc->fi->state == NACC_ST_TX_CELL_CHG_CONTINUE;</span><br><span> </span><br><span>  data_ctx.tbf = tbf;</span><br><span>  data_ctx.msg = NULL;</span><br><span>@@ -969,5 +970,7 @@</span><br><span>   rc = osmo_fsm_inst_dispatch(ms->nacc->fi, NACC_EV_CREATE_RLCMAC_MSG, &data_ctx);</span><br><span>   if (rc != 0 || !data_ctx.msg)</span><br><span>                return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+  if (finish_tbf)</span><br><span style="color: hsl(120, 100%, 40%);">+               tbf_free(tbf);</span><br><span>       return data_ctx.msg;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/22604">change 22604</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/22604"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7cc28922e71699598da0ef6eb90136a47d3c002f </div>
<div style="display:none"> Gerrit-Change-Number: 22604 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>