Change in osmo-gsm-tester[master]: enb, epc: implement stdout/log KPI getter in eNB/EPC base class

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601 )

Change subject: enb,epc: implement stdout/log KPI getter in eNB/EPC base class
......................................................................


Patch Set 1:

(5 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py 
File src/osmo_gsm_tester/obj/enb.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py@358 
PS1, Line 358:     
Remove this whitespace


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py@364 
PS1, Line 364:     def get_log_kpis(self):
I'm not sure what's the point in splitting between log and kpi, is there some rationale behind this?


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py@368 
PS1, Line 368:     def get_num_phy_errors(self, kpi):
What about this function? looks not related to this patch?


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/enb.py@370 
PS1, Line 370:         return 0 
remove trailing whistepace


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/epc.py 
File src/osmo_gsm_tester/obj/epc.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601/1/src/osmo_gsm_tester/obj/epc.py@124 
PS1, Line 124:         return {'total_errors': 0, 'total_warnings': 0}        
remove trailing whitespace



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I7c6c9abf73c2fc1d9104ea082bef6ffa0aeeac32
Gerrit-Change-Number: 22601
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Feb 2021 14:58:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210201/2627b276/attachment.htm>